Remove showSets setting

This commit is contained in:
Brandon Presley 2022-11-05 17:31:18 +13:00
parent 075d038ccc
commit ae84228913
3 changed files with 21 additions and 20 deletions

View File

@ -141,16 +141,14 @@ export default function EditWorkout() {
onSubmitEditing={() => setsRef.current?.focus()} onSubmitEditing={() => setsRef.current?.focus()}
/> />
)} )}
{settings?.showSets && ( <MassiveInput
<MassiveInput innerRef={setsRef}
innerRef={setsRef} value={sets}
value={sets} onChangeText={setSets}
onChangeText={setSets} label="Sets per workout"
label="Sets per workout" keyboardType="numeric"
keyboardType="numeric" onSubmitEditing={() => minutesRef.current?.focus()}
onSubmitEditing={() => minutesRef.current?.focus()} />
/>
)}
{settings?.alarm && ( {settings?.alarm && (
<> <>
<MassiveInput <MassiveInput

View File

@ -30,7 +30,6 @@ export default function SettingsPage() {
const [date, setDate] = useState('%Y-%m-%d %H:%M') const [date, setDate] = useState('%Y-%m-%d %H:%M')
const {theme, setTheme, color, setColor} = useTheme() const {theme, setTheme, color, setColor} = useTheme()
const [showDate, setShowDate] = useState(false) const [showDate, setShowDate] = useState(false)
const [showSets, setShowSets] = useState(false)
const [noSound, setNoSound] = useState(false) const [noSound, setNoSound] = useState(false)
useFocusEffect( useFocusEffect(
@ -46,7 +45,6 @@ export default function SettingsPage() {
setSteps(settings.steps) setSteps(settings.steps)
setDate(settings.date) setDate(settings.date)
setShowDate(settings.showDate) setShowDate(settings.showDate)
setShowSets(settings.showSets)
setNoSound(settings.noSound) setNoSound(settings.noSound)
}) })
}, []), }, []),
@ -120,13 +118,6 @@ export default function SettingsPage() {
else toast('Stopped showing date for sets by default.') else toast('Stopped showing date for sets by default.')
}, []) }, [])
const changeShowSets = useCallback((enabled: boolean) => {
setShowSets(enabled)
settingsRepo.update({}, {showSets: enabled})
if (enabled) toast('Show target sets for workouts.')
else toast('Stopped showing target sets for workouts.')
}, [])
const changeNoSound = useCallback((enabled: boolean) => { const changeNoSound = useCallback((enabled: boolean) => {
setNoSound(enabled) setNoSound(enabled)
settingsRepo.update({}, {noSound: enabled}) settingsRepo.update({}, {noSound: enabled})
@ -143,7 +134,6 @@ export default function SettingsPage() {
{name: 'Show unit', value: showUnit, onChange: changeUnit}, {name: 'Show unit', value: showUnit, onChange: changeUnit},
{name: 'Show steps', value: steps, onChange: changeSteps}, {name: 'Show steps', value: steps, onChange: changeSteps},
{name: 'Show date', value: showDate, onChange: changeShowDate}, {name: 'Show date', value: showDate, onChange: changeShowDate},
{name: 'Show sets', value: showSets, onChange: changeShowSets},
] ]
const changeTheme = useCallback( const changeTheme = useCallback(

View File

@ -0,0 +1,13 @@
import {MigrationInterface, QueryRunner} from 'typeorm'
export class removeShowSets1667622610740 implements MigrationInterface {
public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.dropColumn('settings', 'showSets')
}
public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner
.query('ALTER TABLE settings ADD COLUMN showSets BOOLEAN DEFAULT true')
.catch(() => null)
}
}