From ae842289135b6cc84cdd5dc8a50e8f57e40fb88c Mon Sep 17 00:00:00 2001
From: Brandon Presley <brandon@presley.nz>
Date: Sat, 5 Nov 2022 17:31:18 +1300
Subject: [PATCH] Remove showSets setting

---
 EditWorkout.tsx                              | 18 ++++++++----------
 SettingsPage.tsx                             | 10 ----------
 migrations/1667622610740-remove-show-sets.ts | 13 +++++++++++++
 3 files changed, 21 insertions(+), 20 deletions(-)
 create mode 100644 migrations/1667622610740-remove-show-sets.ts

diff --git a/EditWorkout.tsx b/EditWorkout.tsx
index bb4f5c2..4708cd7 100644
--- a/EditWorkout.tsx
+++ b/EditWorkout.tsx
@@ -141,16 +141,14 @@ export default function EditWorkout() {
               onSubmitEditing={() => setsRef.current?.focus()}
             />
           )}
-          {settings?.showSets && (
-            <MassiveInput
-              innerRef={setsRef}
-              value={sets}
-              onChangeText={setSets}
-              label="Sets per workout"
-              keyboardType="numeric"
-              onSubmitEditing={() => minutesRef.current?.focus()}
-            />
-          )}
+          <MassiveInput
+            innerRef={setsRef}
+            value={sets}
+            onChangeText={setSets}
+            label="Sets per workout"
+            keyboardType="numeric"
+            onSubmitEditing={() => minutesRef.current?.focus()}
+          />
           {settings?.alarm && (
             <>
               <MassiveInput
diff --git a/SettingsPage.tsx b/SettingsPage.tsx
index e52c0ee..0935d98 100644
--- a/SettingsPage.tsx
+++ b/SettingsPage.tsx
@@ -30,7 +30,6 @@ export default function SettingsPage() {
   const [date, setDate] = useState('%Y-%m-%d %H:%M')
   const {theme, setTheme, color, setColor} = useTheme()
   const [showDate, setShowDate] = useState(false)
-  const [showSets, setShowSets] = useState(false)
   const [noSound, setNoSound] = useState(false)
 
   useFocusEffect(
@@ -46,7 +45,6 @@ export default function SettingsPage() {
         setSteps(settings.steps)
         setDate(settings.date)
         setShowDate(settings.showDate)
-        setShowSets(settings.showSets)
         setNoSound(settings.noSound)
       })
     }, []),
@@ -120,13 +118,6 @@ export default function SettingsPage() {
     else toast('Stopped showing date for sets by default.')
   }, [])
 
-  const changeShowSets = useCallback((enabled: boolean) => {
-    setShowSets(enabled)
-    settingsRepo.update({}, {showSets: enabled})
-    if (enabled) toast('Show target sets for workouts.')
-    else toast('Stopped showing target sets for workouts.')
-  }, [])
-
   const changeNoSound = useCallback((enabled: boolean) => {
     setNoSound(enabled)
     settingsRepo.update({}, {noSound: enabled})
@@ -143,7 +134,6 @@ export default function SettingsPage() {
     {name: 'Show unit', value: showUnit, onChange: changeUnit},
     {name: 'Show steps', value: steps, onChange: changeSteps},
     {name: 'Show date', value: showDate, onChange: changeShowDate},
-    {name: 'Show sets', value: showSets, onChange: changeShowSets},
   ]
 
   const changeTheme = useCallback(
diff --git a/migrations/1667622610740-remove-show-sets.ts b/migrations/1667622610740-remove-show-sets.ts
new file mode 100644
index 0000000..08d4086
--- /dev/null
+++ b/migrations/1667622610740-remove-show-sets.ts
@@ -0,0 +1,13 @@
+import {MigrationInterface, QueryRunner} from 'typeorm'
+
+export class removeShowSets1667622610740 implements MigrationInterface {
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.dropColumn('settings', 'showSets')
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner
+      .query('ALTER TABLE settings ADD COLUMN showSets BOOLEAN DEFAULT true')
+      .catch(() => null)
+  }
+}