brandon.presley/Massive
brandon.presley
/
Massive
4
8
Fork 3
Code Issues 14 Pull Requests Activity

Add missing deps to callbacks

This commit is contained in:
Brandon Presley 2022-07-10 11:54:23 +12:00
parent cba57e6e64
commit 4faad97c13
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
EditPlan.tsx
View File

@ -49,7 +49,7 @@ export default function EditPlan({
); );
setPlan(undefined); setPlan(undefined);
onSave(); onSave();
}, [days, workouts, db]); }, [days, workouts, db, onSave, plan, setPlan]);
const toggleWorkout = useCallback( const toggleWorkout = useCallback(
(on: boolean, name: string) => { (on: boolean, name: string) => {
@ -59,7 +59,7 @@ export default function EditPlan({
setWorkouts(workouts.filter(workout => workout !== name)); setWorkouts(workouts.filter(workout => workout !== name));
} }
}, },
[setWorkouts], [setWorkouts, workouts],
); );
const toggleDay = useCallback( const toggleDay = useCallback(
@ -70,7 +70,7 @@ export default function EditPlan({
setDays(days.filter(d => d !== day)); setDays(days.filter(d => d !== day));
} }
}, },
[setDays], [setDays, days],
); );
return ( return (

2
PlanItem.tsx
View File

@ -21,7 +21,7 @@ export default function PlanItem({
await db.executeSql(`DELETE FROM plans WHERE id = ?`, [item.id]); await db.executeSql(`DELETE FROM plans WHERE id = ?`, [item.id]);
setShow(false); setShow(false);
onRemove(); onRemove();
}, [db, setShow]); }, [db, setShow, item.id, onRemove]);
const longPress = useCallback( const longPress = useCallback(
(e: GestureResponderEvent) => { (e: GestureResponderEvent) => {

4
SetItem.tsx
View File

@ -21,14 +21,14 @@ export default function SetItem({
await db.executeSql(`DELETE FROM sets WHERE id = ?`, [item.id]); await db.executeSql(`DELETE FROM sets WHERE id = ?`, [item.id]);
setShow(false); setShow(false);
onRemove(); onRemove();
}, [setShow, db]); }, [setShow, db, onRemove, item.id]);
const copy = useCallback(() => { const copy = useCallback(() => {
const set = {...item}; const set = {...item};
delete set.id; delete set.id;
setSet(set); setSet(set);
setShow(false); setShow(false);
}, [setSet, setShow]); }, [setSet, setShow, item]);
const longPress = useCallback( const longPress = useCallback(
(e: GestureResponderEvent) => { (e: GestureResponderEvent) => {