From 4faad97c13614818105ed5cb16a70e374f93ec03 Mon Sep 17 00:00:00 2001 From: Brandon Presley Date: Sun, 10 Jul 2022 11:54:23 +1200 Subject: [PATCH] Add missing deps to callbacks --- EditPlan.tsx | 6 +++--- PlanItem.tsx | 2 +- SetItem.tsx | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/EditPlan.tsx b/EditPlan.tsx index 354e34b..fa57ba1 100644 --- a/EditPlan.tsx +++ b/EditPlan.tsx @@ -49,7 +49,7 @@ export default function EditPlan({ ); setPlan(undefined); onSave(); - }, [days, workouts, db]); + }, [days, workouts, db, onSave, plan, setPlan]); const toggleWorkout = useCallback( (on: boolean, name: string) => { @@ -59,7 +59,7 @@ export default function EditPlan({ setWorkouts(workouts.filter(workout => workout !== name)); } }, - [setWorkouts], + [setWorkouts, workouts], ); const toggleDay = useCallback( @@ -70,7 +70,7 @@ export default function EditPlan({ setDays(days.filter(d => d !== day)); } }, - [setDays], + [setDays, days], ); return ( diff --git a/PlanItem.tsx b/PlanItem.tsx index bccd706..5c3e634 100644 --- a/PlanItem.tsx +++ b/PlanItem.tsx @@ -21,7 +21,7 @@ export default function PlanItem({ await db.executeSql(`DELETE FROM plans WHERE id = ?`, [item.id]); setShow(false); onRemove(); - }, [db, setShow]); + }, [db, setShow, item.id, onRemove]); const longPress = useCallback( (e: GestureResponderEvent) => { diff --git a/SetItem.tsx b/SetItem.tsx index 9131b16..e2816b6 100644 --- a/SetItem.tsx +++ b/SetItem.tsx @@ -21,14 +21,14 @@ export default function SetItem({ await db.executeSql(`DELETE FROM sets WHERE id = ?`, [item.id]); setShow(false); onRemove(); - }, [setShow, db]); + }, [setShow, db, onRemove, item.id]); const copy = useCallback(() => { const set = {...item}; delete set.id; setSet(set); setShow(false); - }, [setSet, setShow]); + }, [setSet, setShow, item]); const longPress = useCallback( (e: GestureResponderEvent) => {