brandon.presley/Massive
brandon.presley
/
Massive
4
8
Fork 3
Code Issues 14 Pull Requests Activity

WIP: Fix TimerService crashing on Android 14 #229

Closed
joseph wants to merge 0 commits from joseph/Massive:master into master
pull from: joseph/Massive:master
merge into: brandon.presley:master
Conversation 1 Commits - Files Changed -
joseph commented 2024-02-29 13:44:57 +00:00
Contributor
Copy Link

This should fix #228, where on android 14, when using auto timer, after recording another set the app crashes.

The android docs on the Android 14 changes to foreground services is here: https://developer.android.com/about/versions/14/changes/fgs-types-required

I have tested this on Android 14 and the timers now work.

However I am not sure if FOREGROUND_SERVICE_SPECIAL_USE is the correct permission for this app, or if the explanation I provided in the Manifest is adequate.

This should fix https://gitea.presley.nz/brandon.presley/Massive/issues/228, where on android 14, when using auto timer, after recording another set the app crashes. The android docs on the Android 14 changes to foreground services is here: https://developer.android.com/about/versions/14/changes/fgs-types-required I have tested this on Android 14 and the timers now work. However I am not sure if `FOREGROUND_SERVICE_SPECIAL_USE` is the correct permission for this app, or if the explanation I provided in the Manifest is adequate.
joseph added 1 commit 2024-02-29 13:44:57 +00:00
brandon.presley commented 2024-03-01 07:06:20 +00:00
Owner
Copy Link

I can't say whether this fixes anything or not, since I can't replicate any timer errors on my device or any emulators.
However I can say this change didn't cause any extra issues on my devices and my emulators, so I'll accept it.

Google play is making me give them a video and explain why we need these permissions so it will take a while before it's approved or rejected by the play store. I'll close these tickets for now and if we get rejected then it's tough luck.

I can't say whether this fixes anything or not, since I can't replicate any timer errors on my device or any emulators. However I can say this change didn't cause any extra issues on my devices and my emulators, so I'll accept it. Google play is making me give them a video and explain why we need these permissions so it will take a while before it's approved or rejected by the play store. I'll close these tickets for now and if we get rejected then it's tough luck.
brandon.presley closed this pull request 2024-03-01 07:06:20 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: brandon.presley/Massive#229
No description provided.
Delete Branch "joseph/Massive:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?