brandon.presley/Massive
brandon.presley
/
Massive
4
8
Fork 3
Code Issues 14 Pull Requests Activity

feature: Add title to Plan #166

Closed
Nuice wants to merge 0 commits from Nuice/Massive:master into master
pull from: Nuice/Massive:master
merge into: brandon.presley:master
Conversation 6 Commits - Files Changed -
Nuice commented 2023-08-21 12:34:19 +00:00
First-time contributor
Copy Link

Feature

I suggest adding a title to Plan, as it's better and easier to seperate each Plan.

Before

image

After

image
image

When no title is set, the days are displayed as before:

image

PS.
I really like this app and I started using it regularly as my main gym tracker (progressive overload etc.). I'm really looking forward to contribute and help this app getting better.

### Feature I suggest adding a title to Plan, as it's better and easier to seperate each Plan. #### Before ![image](/attachments/dc59c0cd-ff29-4e13-b14a-d17d00c9aa96) #### After ![image](/attachments/bc3bcac6-786c-434f-a4bd-dc7e88b6a863) ![image](/attachments/e48d7fe5-2523-4a2a-a39e-8407b884fcb1) When no title is set, the days are displayed as before: ![image](/attachments/901f6176-12e7-49ff-a3ce-90881fffee27) PS. I really like this app and I started using it regularly as my main gym tracker (progressive overload etc.). I'm really looking forward to contribute and help this app getting better.
image.png
29 KiB
image.png
24 KiB
image.png
76 KiB
image.png
30 KiB
Nuice added 1 commit 2023-08-21 12:34:20 +00:00
brandon.presley commented 2023-08-21 21:22:22 +00:00
Owner
Copy Link

Very nice thanks for the contribution!
Will test + merge later today.

Very nice thanks for the contribution! Will test + merge later today.
brandon.presley commented 2023-08-21 22:04:29 +00:00
Owner
Copy Link

Changes were good except for one thing, the migrations. Fixed and pushed it all so no worries but if you are interested the details are here:
2a6ba3b36a d2cad451fe

Changes were good except for one thing, the migrations. Fixed and pushed it all so no worries but if you are interested the details are here: 2a6ba3b36a852a4aae5c8049bef80f0191841060 d2cad451feb353717d478f3f5112d0cce97fa725
👍 1
brandon.presley closed this pull request 2023-08-21 22:04:29 +00:00
Nuice commented 2023-08-22 08:09:25 +00:00
Author
First-time contributor
Copy Link

Great, thank you very much!

Great, thank you very much!
Nuice commented 2023-08-22 08:11:26 +00:00
Author
First-time contributor
Copy Link

@brandon.presley how should I do migrations in future? I changed them manually in this PR...

@brandon.presley how should I do migrations in future? I changed them manually in this PR...
brandon.presley commented 2023-08-23 00:31:43 +00:00
Owner
Copy Link

@Nuice you want to create a new migration and make sure that migration is listed in the data-source

@Nuice you want to create a [new migration](https://orkhan.gitbook.io/typeorm/docs/migrations#creating-a-new-migration) and make sure that migration is listed in the [data-source](https://gitea.presley.nz/brandon.presley/Massive/commit/d2cad451feb353717d478f3f5112d0cce97fa725#diff-e501eead9d3737a3085dd371374a358ff6abf2d8)
brandon.presley commented 2023-08-23 00:32:16 +00:00
Owner
Copy Link

If you edit an old migration like you did then while that might work for a fresh install of the app, it won't work for people updating the app.

If you edit an old migration like you did then while that might work for a fresh install of the app, it won't work for people updating the app.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: brandon.presley/Massive#166
No description provided.
Delete Branch "Nuice/Massive:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?