From 3fdc5900e382082d7bb4a096233d1a2538d8df0c Mon Sep 17 00:00:00 2001 From: Brandon Presley Date: Fri, 30 Dec 2022 20:37:08 +1300 Subject: [PATCH] Improve performance of setttings toggles I was awaiting the result of the sqlite operations when really I should have just set the state immediately, and done the operations in the background. --- SettingsPage.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SettingsPage.tsx b/SettingsPage.tsx index 3d3ce74..064c1b7 100644 --- a/SettingsPage.tsx +++ b/SettingsPage.tsx @@ -79,8 +79,8 @@ export default function SettingsPage() { const changeString = useCallback( async (key: keyof Settings, value: string) => { - await settingsRepo.save({...settings, [key]: value}) setValue(key, value) + await settingsRepo.save({...settings, [key]: value}) switch (key) { case 'date': return toast('Changed date format') @@ -107,8 +107,8 @@ export default function SettingsPage() { const changeBoolean = useCallback( async (key: keyof Settings, value: boolean) => { - await settingsRepo.save({...settings, [key]: value}) setValue(key, value) + await settingsRepo.save({...settings, [key]: value}) switch (key) { case 'alarm': if (value) toast('Timers will now run after each set.')