feature req: stop alarm and restart on save #212

New Issue

nutpants · 2023-12-27T17:35:57Z

nutpants commented

2023-12-27 17:35:57 +00:00

When saving a set it would be nice if it would automatically stop any alarms and timers in progress and start the new timer for alarm. Would save a lot of time.

It may already do this but some times it
Does not.

When saving a set it would be nice if it would automatically stop any alarms and timers in progress and start the new timer for alarm. Would save a lot of time. It may already do this but some times it Does not.

brandon.presley commented

2024-02-05 01:44:03 +00:00

The current code for running an alarm already calls to cancel the timer + notification + alarm:

    fun timer(milliseconds: Int) {
        Log.d("AlarmModule", "Queue alarm for $milliseconds delay")
        val manager = getManager()
        manager.cancel(AlarmService.NOTIFICATION_ID_DONE)
        val intent = Intent(reactApplicationContext, AlarmService::class.java)
        reactApplicationContext.stopService(intent)
        countdownTimer?.cancel()
        countdownTimer = getTimer(milliseconds)
        countdownTimer?.start()
        running = true
    }

Perhaps this ticket should be a bug report instead. In which case please provide:

App version
Steps to re-produce
ADB logs

The current code for running an alarm already calls to cancel the timer + notification + alarm: ```kotlin fun timer(milliseconds: Int) { Log.d("AlarmModule", "Queue alarm for $milliseconds delay") val manager = getManager() manager.cancel(AlarmService.NOTIFICATION_ID_DONE) val intent = Intent(reactApplicationContext, AlarmService::class.java) reactApplicationContext.stopService(intent) countdownTimer?.cancel() countdownTimer = getTimer(milliseconds) countdownTimer?.start() running = true } ``` Perhaps this ticket should be a bug report instead. In which case please provide: 1. App version 2. Steps to re-produce 3. ADB logs

brandon.presley added the

bug

question

labels 2024-02-05 01:44:07 +00:00

brandon.presley referenced this issue from a commit

2024-02-16 01:09:06 +00:00

Move timer logic from AlarmModule -> TimerService

brandon.presley referenced this issue from a commit

2024-02-17 06:11:10 +00:00

Remove all JS side Timers

brandon.presley closed this issue

2024-02-17 06:11:10 +00:00