Use the user's time and date format #116

New Issue

inhji · 2022-11-11T20:40:24Z

inhji commented

2022-11-11 20:40:24 +00:00

The datetime format setting could be simpler and more straightforward, if you adopted the system setting for the date and time format on the user's device.

I've seen you adding more and more different date and time settings, and I personally find them very useful.

However, the one I'm using right now, "Monday 3:05 PM", does not use the 24-hour time format nor the German date format.

Using the user's system setting would allow you to keep all of the existing formats but have them still display time and date according to the user's preference.

Cheers!

The datetime format setting could be simpler and more straightforward, if you adopted the system setting for the date and time format on the user's device. I've seen you adding more and more different date and time settings, and I personally find them very useful. However, the one I'm using right now, "Monday 3:05 PM", does not use the 24-hour time format nor the German date format. Using the user's system setting would allow you to keep all of the existing formats but have them still display time and date according to the user's preference. Cheers!

brandon.presley commented

2022-11-11 21:48:42 +00:00

I'll give it a shot. The way the date formatting works currently just splits the string and pulls out numbers, rather than using a proper date library like date-fns or Moment.js. I probably avoided them because I ran into some errors locally but might work next time I attempt it.

brandon.presley added the

enhancement

label 2022-11-11 21:53:19 +00:00

brandon.presley commented

2022-11-12 01:38:16 +00:00

I have the 12/24 hour detection working, but the locale stuff I might do later. If i'm lucky this default way they format the dates will take into account the users locale.

brandon.presley referenced this issue from a commit

2022-11-12 03:00:20 +00:00

Use date-fns and detect 12/24 hour device setting

inhji commented

2022-11-13 10:45:03 +00:00

Sounds awesome, I'd be happy to provide feedback once this version makes its way to fdroid!

brandon.presley commented

2022-11-14 23:00:45 +00:00

Found a bug where the setting for date gets reset when navigating back to the settings page. Commenting here instead of making a new issue.

brandon.presley commented

2022-11-17 21:20:07 +00:00

That library I put in it to detect the users date/24hr setting is wonky and breaking my ios build. I'll just make an android native module myself to detect it. Probably easy.

brandon.presley commented

2022-11-30 01:44:11 +00:00

@inhji the version currently on f-droid (1.76) looks like it's detecting 24 hour settings successfully. However it isn't doing the detection based on focusing the screen (just does it on app startup). Future versions will do this though.

inhji commented

2022-11-30 06:30:02 +00:00

I've seen it, works very well. I do think detecting the setting in startup is more than enough, since that setting should not change very often, if at all.

brandon.presley commented

2022-11-30 06:46:26 +00:00

Perfect. As for the different language support, I don't think I'll add that any time soon. If anybody else makes a merge request to add it I will gladly review + accept. But otherwise I imagine it will remain English only.

brandon.presley closed this issue

2022-11-30 06:46:26 +00:00

Sign in to join this conversation.