From a284f045d244e1f773b8b529b586f977132ee4ad Mon Sep 17 00:00:00 2001
From: Brandon Presley <brandon@presley.nz>
Date: Thu, 1 Dec 2022 15:45:18 +1300
Subject: [PATCH] Add left padding to settings selects

---
 SettingsPage.tsx | 145 +++++++++++++++++++----------------------------
 constants.ts     |   1 +
 input.ts         |   3 +
 options.ts       |  19 +++++++
 4 files changed, 81 insertions(+), 87 deletions(-)
 create mode 100644 options.ts

diff --git a/SettingsPage.tsx b/SettingsPage.tsx
index 552b5f0..868ba82 100644
--- a/SettingsPage.tsx
+++ b/SettingsPage.tsx
@@ -11,11 +11,11 @@ import {
 } from 'react-native'
 import DocumentPicker from 'react-native-document-picker'
 import {Button, Subheading} from 'react-native-paper'
-import {darkColors, lightColors} from './colors'
-import {MARGIN} from './constants'
+import {ITEM_PADDING, MARGIN} from './constants'
 import {settingsRepo} from './db'
 import DrawerHeader from './DrawerHeader'
 import Input from './input'
+import {darkOptions, lightOptions, themeOptions} from './options'
 import Page from './Page'
 import Select from './Select'
 import Switch from './Switch'
@@ -142,38 +142,16 @@ export default function SettingsPage() {
     else toast('Enabled sound for rest timer alarms.')
   }, [])
 
-  const switches: Input<boolean>[] = useMemo(
-    () =>
-      [
-        {name: 'Rest timers', value: alarm, onChange: changeAlarmEnabled},
-        {name: 'Vibrate', value: vibrate, onChange: changeVibrate},
-        {name: 'Disable sound', value: noSound, onChange: changeNoSound},
-        {name: 'Notifications', value: notify, onChange: changeNotify},
-        {name: 'Show images', value: images, onChange: changeImages},
-        {name: 'Show unit', value: showUnit, onChange: changeUnit},
-        {name: 'Show steps', value: steps, onChange: changeSteps},
-        {name: 'Show date', value: showDate, onChange: changeShowDate},
-      ].filter(({name}) => name.toLowerCase().includes(term.toLowerCase())),
-    [
-      term,
-      showDate,
-      changeShowDate,
-      alarm,
-      changeAlarmEnabled,
-      vibrate,
-      changeVibrate,
-      noSound,
-      changeNoSound,
-      notify,
-      changeNotify,
-      images,
-      changeImages,
-      showUnit,
-      changeUnit,
-      steps,
-      changeSteps,
-    ],
-  )
+  const switches: Input<boolean>[] = [
+    {name: 'Rest timers', value: alarm, onChange: changeAlarmEnabled},
+    {name: 'Vibrate', value: vibrate, onChange: changeVibrate},
+    {name: 'Disable sound', value: noSound, onChange: changeNoSound},
+    {name: 'Notifications', value: notify, onChange: changeNotify},
+    {name: 'Show images', value: images, onChange: changeImages},
+    {name: 'Show unit', value: showUnit, onChange: changeUnit},
+    {name: 'Show steps', value: steps, onChange: changeSteps},
+    {name: 'Show date', value: showDate, onChange: changeShowDate},
+  ].filter(({name}) => name.toLowerCase().includes(term.toLowerCase()))
 
   const changeTheme = useCallback(
     (value: string) => {
@@ -210,7 +188,7 @@ export default function SettingsPage() {
     [setLightColor],
   )
 
-  const renderItem = useCallback(
+  const renderSwitch = useCallback(
     ({item}: {item: Input<boolean>}) => (
       <Switch
         onPress={() => item.onChange(!item.value)}
@@ -223,6 +201,44 @@ export default function SettingsPage() {
     [],
   )
 
+  const selects: Input<string>[] = [
+    {name: 'Theme', value: theme, onChange: changeTheme, items: themeOptions},
+    {
+      name: 'Dark color',
+      value: darkColor,
+      onChange: changeDarkColor,
+      items: lightOptions,
+    },
+    {
+      name: 'Light color',
+      value: lightColor,
+      onChange: changeLightColor,
+      items: darkOptions,
+    },
+    {
+      name: 'Date format',
+      value: date,
+      onChange: changeDate,
+      items: formatOptions.map(option => ({
+        label: format(today, option),
+        value: option,
+      })),
+    },
+  ].filter(({name}) => name.toLowerCase().includes(term.toLowerCase()))
+
+  const renderSelect = useCallback(
+    ({item}: {item: Input<string>}) => (
+      <Select
+        value={item.value}
+        onChange={item.onChange}
+        label={item.name}
+        style={styles.select}
+        items={item.items}
+      />
+    ),
+    [],
+  )
+
   return (
     <>
       <DrawerHeader name="Settings" />
@@ -230,64 +246,19 @@ export default function SettingsPage() {
         <FlatList
           style={{marginTop: MARGIN}}
           data={switches}
-          renderItem={renderItem}
+          renderItem={renderSwitch}
+        />
+        <FlatList
+          style={{paddingLeft: ITEM_PADDING}}
+          data={selects}
+          renderItem={renderSelect}
         />
-        {'theme'.includes(term.toLowerCase()) && (
-          <Select
-            label="Theme"
-            value={theme}
-            onChange={changeTheme}
-            style={styles.select}
-            items={[
-              {label: 'Follow system theme', value: 'system'},
-              {label: 'Dark theme', value: 'dark'},
-              {label: 'Light theme', value: 'light'},
-            ]}
-          />
-        )}
-        {'color'.includes(term.toLowerCase()) && (
-          <Select
-            label="Dark color"
-            value={darkColor}
-            onChange={changeDarkColor}
-            style={styles.select}
-            items={lightColors.map(color => ({
-              label: color.name,
-              value: color.hex,
-              color: color.hex,
-            }))}
-          />
-        )}
-        {'color'.includes(term.toLowerCase()) && (
-          <Select
-            value={lightColor}
-            onChange={changeLightColor}
-            label="Light color"
-            style={styles.select}
-            items={darkColors.map(color => ({
-              label: color.name,
-              value: color.hex,
-              color: color.hex,
-            }))}
-          />
-        )}
-        {'date format'.includes(term.toLowerCase()) && (
-          <Select
-            value={date}
-            onChange={changeDate}
-            label="Date format"
-            style={styles.select}
-            items={formatOptions.map(option => ({
-              label: format(today, option),
-              value: option,
-            }))}
-          />
-        )}
         {'alarm sound'.includes(term.toLowerCase()) && (
           <View
             style={{
               flexDirection: 'row',
               alignItems: 'center',
+              paddingLeft: ITEM_PADDING,
             }}>
             <Subheading style={styles.select}>Alarm sound</Subheading>
             <Button onPress={changeSound}>{soundString || 'Default'}</Button>
diff --git a/constants.ts b/constants.ts
index f8c3a3a..265aad6 100644
--- a/constants.ts
+++ b/constants.ts
@@ -1,2 +1,3 @@
 export const MARGIN = 10
 export const PADDING = 10
+export const ITEM_PADDING = 8
diff --git a/input.ts b/input.ts
index 22e7fde..ab1e5ec 100644
--- a/input.ts
+++ b/input.ts
@@ -1,5 +1,8 @@
+import {Item} from './Select'
+
 export default interface Input<T> {
   name: string
   value?: T
   onChange: (value: T) => void
+  items?: Item[]
 }
diff --git a/options.ts b/options.ts
new file mode 100644
index 0000000..baec9d4
--- /dev/null
+++ b/options.ts
@@ -0,0 +1,19 @@
+import {darkColors, lightColors} from './colors'
+
+export const themeOptions = [
+  {label: 'Follow system theme', value: 'system'},
+  {label: 'Dark theme', value: 'dark'},
+  {label: 'Light theme', value: 'light'},
+]
+
+export const lightOptions = lightColors.map(color => ({
+  label: color.name,
+  value: color.hex,
+  color: color.hex,
+}))
+
+export const darkOptions = darkColors.map(color => ({
+  label: color.name,
+  value: color.hex,
+  color: color.hex,
+}))