Remove dates toggle from set item

This feature exists in the settings page,
so duplicating it here might be confusing to users.
This commit is contained in:
Brandon Presley 2022-10-12 14:10:59 +13:00
parent e7438138a6
commit 636bfa35a4
2 changed files with 4 additions and 22 deletions

View File

@ -10,13 +10,9 @@ import {useSettings} from './use-settings';
export default function SetItem({
item,
onRemove,
dates,
setDates,
}: {
item: Set;
onRemove: () => void;
dates: boolean;
setDates: (value: boolean) => void;
}) {
const [showMenu, setShowMenu] = useState(false);
const [anchor, setAnchor] = useState({x: 0, y: 0});
@ -44,11 +40,6 @@ export default function SetItem({
[setShowMenu, setAnchor],
);
const toggleDates = useCallback(() => {
setDates(!dates);
setShowMenu(false);
}, [dates, setDates]);
return (
<>
<List.Item
@ -64,7 +55,7 @@ export default function SetItem({
}
right={() => (
<>
{dates && (
{!!settings.showDate && (
<Text
style={{
alignSelf: 'center',
@ -77,7 +68,6 @@ export default function SetItem({
visible={showMenu}
onDismiss={() => setShowMenu(false)}>
<Menu.Item icon="content-copy" onPress={copy} title="Copy" />
<Menu.Item icon="event" onPress={toggleDates} title="Dates" />
<Divider />
<Menu.Item icon="delete" onPress={remove} title="Delete" />
</Menu>

View File

@ -23,7 +23,6 @@ export default function SetList() {
const [search, setSearch] = useState('');
const [end, setEnd] = useState(false);
const {settings} = useSettings();
const [dates, setDates] = useState(!!settings.showDate);
const navigation = useNavigation<NavigationProp<HomePageParams>>();
const refresh = useCallback(async () => {
@ -48,8 +47,7 @@ export default function SetList() {
navigation.getParent()?.setOptions({
headerRight: () => <DrawerMenu name="Home" />,
});
setDates(!!settings.showDate);
}, [refresh, navigation, settings.showDate]),
}, [refresh, navigation]),
);
useEffect(() => {
@ -58,15 +56,9 @@ export default function SetList() {
const renderItem = useCallback(
({item}: {item: Set}) => (
<SetItem
dates={dates}
setDates={setDates}
item={item}
key={item.id}
onRemove={refresh}
/>
<SetItem item={item} key={item.id} onRemove={refresh} />
),
[refresh, dates, setDates],
[refresh],
);
const next = useCallback(async () => {